Phase Two Change Log

Known Issues (Fix These)

Document title uniqueness checks fail for titles containing single or double quotes.

I think we should use str_replace("'", "''", $str) instead of mysql_real_escape_string, which puts weird slashes in. I believe I've seen phpMyAdmin use that form of replacement, replacing single quotes with two single quotes.

Problem: Upon proposal approval, the WasApproved flag in the database was not changed from 0 to 1. This led the system to report that the proposal was rejected, even though it was approved and the section had been updated.
Solution: Added "WasApproved = 1" to UPDATE query.

[2007.03.27 15:15] Fixed possible issue in Proposal::getTotalVotesNeededToApprove()

Problem: If the vote was currently open, the system would check the number of users that could vote on the Proposal by looking at UserSectionProposal rows. Otherwise, it would look at who has permission to vote on the Proposal. But there will be UserSectionProposal rows even if the vote was closed, or more precisely, if the vote was ever open.
Solution: Changed if condition from "$this->isVoteOpen" to "$this->voteOpenTime"

Problem: Upon proposal approval, when linking the proposal to the destination SectionVersion, the SectionVersionId given to the query is not a SectionVersionId at all, but the latest VersionNumber of the Section.
Solution:

Created Section::getLatestVersionId() which retrieves the latest SectionVersionId for its Section
Changed "$section->getVersionNumber()" to "$section->getLatestVersionId()"

Problem: If the query fails, "$userId()" was printed out in the exception message.
Solution: Changed "$userId()" to "$userId"

Problem: If not all Members had permission to vote on the Proposal on which the vote was being opened, the system retrieved the UserIds of the Users who had permission to vote on the Proposal via the UserCommittee and DocumentCommittee tables. If any one User was a member of more than one Committee that had Vote permission on the Proposal's Document, that User would be retrieved twice, and more than one UserSectionProposal row would be inserted for that User and this Proposal.
Solution: Replaced "SELECT DC.UserId" with "SELECT DISTINCT DC.UserId"